Fix the bug that accept attribute in the input field didn't work properly #2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryubro
requested review from
tlouisse,
gerjanvangeest,
narzac,
Knorgias and
okadurin
as code owners
🦋 Changeset detectedLatest commit: ac9d16b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ryubro
commented
Sep 3, 2024
| @@ -158,6 +158,17 @@ describe('lion-input-file', () => { | |||
| }) | |||
| ); | |||
|
|
|||
| it('error should not be there when the file extensions are accepted', async () => { | |||
There was a problem hiding this comment.
This test was failing before the fix
gerjanvangeest
approved these changes
Sep 5, 2024
okadurin
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
acceptattribute in the input field didn't work., theIsAcceptedFilevalidator always fails. (It tries to comparejpg(from the accept attirbute) and.jpg(from file name)hasFeedbackForproperty of thelion-input-filefrom the inspector., the file dialog disable those file with the extensions (accept="jpg"will make jpg files unselectable - actually all files become unselectible)Technically breaking change
Apparently we officially supported extensions without
.for theacceptattribute, but this is not a valid accept attribute and breaks the behaviour of browsers (tested on Chrome 128.0.6613.114, Mac). So I removed the normalization (removing.) of the extension and the relevant test.It's technically a breaking change, but it seems rather a bug fix, to me (if a consumer used extensions without
., it would break the browser behavior, anyway)